Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes to get all pytest running GREEN #219

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

maximilien
Copy link
Collaborator

@maximilien maximilien commented Feb 12, 2025

Execute as follows:

(maestro-py3.12) (base) ➜  maestro git:(issue217) pwd
/Users/maximilien/github/beeai-labs/maestro
(maestro-py3.12) (base) ➜  maestro git:(issue217) pytest
======================================== test session starts ========================================
...
========================================= 8 passed in 1.10s =========================================

Full test run here: pytest_green.txt

Next steps:

  • pytest runs green

@akihikokuroda if you can help with the other items in this list then feel free to open separate issue and close it here

@maximilien maximilien self-assigned this Feb 12, 2025
@maximilien
Copy link
Collaborator Author

@george-lhj and @akihikokuroda please review this independently. If ready to merge let's do it and I can move the remaining TODOs to a seperate issue. Want to move fast. Thanks.

@maximilien maximilien linked an issue Feb 12, 2025 that may be closed by this pull request
@maximilien
Copy link
Collaborator Author

FYI... addressing Maestro Check Schema / check-schema (pull_request) failing tests

FYI: @akihikokuroda

@maximilien
Copy link
Collaborator Author

OK resolving conflicts with rebase.

FYI @akihikokuroda will try to do as much as I can in between meetings.

@maximilien
Copy link
Collaborator Author

Let's merge this @akihikokuroda and I will move the remaining CI fails to issue #221

Copy link
Collaborator

@akihikokuroda akihikokuroda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akihikokuroda akihikokuroda merged commit 8e9f196 into i-am-bee:main Feb 13, 2025
1 of 3 checks passed
george-lhj pushed a commit that referenced this pull request Feb 14, 2025
* various changes to get all tests passing via running pytest in the root maestro directory

* address CI check-schema failures

* fixing imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI issues after restructure
2 participants